Let workflows move cards by start date instead of due date

Each workflow now has a trigger date (due or start): the runner compares
either the card's due date or its start date against now, read straight
from Deck's Card entity. Mails and Nextcloud notifications say whether
the card was overdue or reached its start date. Cards without the chosen
date stay put.

Deck only has a start date since 1.18 and Entity getters are magic, so
DeckIntegrationService::supportsStartdate() checks the property; without
it the form rejects start-date workflows and the runner skips them
without disabling them.

WorkflowRunner::isOverdue() becomes hasPassed(), as it now covers both
dates. Existing workflows keep the due date (migration Version1005).
Bumps to 35.4.0 so the migration runs.

lib/Controller/WorkflowController.php

@@ -9,6 +9,7 @@ use OCA\WorkflowDeckAutomation\Db\WorkflowMapper;
 use OCA\WorkflowDeckAutomation\Service\DeckIntegrationService;
 use OCA\WorkflowDeckAutomation\Service\DeckUnavailableException;
 use OCA\WorkflowDeckAutomation\Service\NotificationPolicy;
+use OCA\WorkflowDeckAutomation\Service\TriggerDate;
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\NoAdminRequired;
@@ -56,15 +57,16 @@ class WorkflowController extends OCSController {
 		int $boardId,
 		int $sourceStackId,
 		int $targetStackId,
+		string $triggerDate = TriggerDate::DUE,
 		string $notifyMode = NotificationPolicy::MODE_OFF,
 		string $notifyChannel = NotificationPolicy::CHANNEL_MAIL,
 		bool $enabled = true,
 	): DataResponse {
-		$this->validate($title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $notifyChannel);
+		$this->validate($title, $boardId, $sourceStackId, $targetStackId, $triggerDate, $notifyMode, $notifyChannel);
 
 		$workflow = new Workflow();
 		$workflow->setUserId($this->currentUserId());
-		$this->applyFields($workflow, $title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $notifyChannel, $enabled);
+		$this->applyFields($workflow, $title, $boardId, $sourceStackId, $targetStackId, $triggerDate, $notifyMode, $notifyChannel, $enabled);
 
 		$workflow = $this->workflowMapper->insert($workflow);
 		return new DataResponse($workflow->jsonSerialize(), Http::STATUS_CREATED);
@@ -77,17 +79,18 @@ class WorkflowController extends OCSController {
 		int $boardId,
 		int $sourceStackId,
 		int $targetStackId,
+		string $triggerDate = TriggerDate::DUE,
 		string $notifyMode = NotificationPolicy::MODE_OFF,
 		string $notifyChannel = NotificationPolicy::CHANNEL_MAIL,
 		bool $enabled = true,
 	): DataResponse {
 		$workflow = $this->findOwnWorkflow($id);
-		$this->validate($title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $notifyChannel);
+		$this->validate($title, $boardId, $sourceStackId, $targetStackId, $triggerDate, $notifyMode, $notifyChannel);
 
 		// Kept in step with the board owner so the job runs as, and mails,
 		// the right user; validate() made sure the editor owns the board.
 		$workflow->setUserId($this->currentUserId());
-		$this->applyFields($workflow, $title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $notifyChannel, $enabled);
+		$this->applyFields($workflow, $title, $boardId, $sourceStackId, $targetStackId, $triggerDate, $notifyMode, $notifyChannel, $enabled);
 		$workflow = $this->workflowMapper->update($workflow);
 
 		return new DataResponse($workflow->jsonSerialize());
@@ -158,13 +161,16 @@ class WorkflowController extends OCSController {
 		}
 	}
 
-	private function validate(string $title, int $boardId, int $sourceStackId, int $targetStackId, string $notifyMode, string $notifyChannel): void {
+	private function validate(string $title, int $boardId, int $sourceStackId, int $targetStackId, string $triggerDate, string $notifyMode, string $notifyChannel): void {
 		if (trim($title) === '') {
 			throw new OCSBadRequestException('Bitte einen Titel angeben.');
 		}
 		if ($sourceStackId === $targetStackId) {
 			throw new OCSBadRequestException('Quell- und Ziel-Stapel müssen sich unterscheiden.');
 		}
+		if (!TriggerDate::isValid($triggerDate)) {
+			throw new OCSBadRequestException('Ungültiges Datum für die Verschiebung, erlaubt sind: ' . implode(', ', TriggerDate::ALL));
+		}
 		if (!NotificationPolicy::isValidMode($notifyMode)) {
 			throw new OCSBadRequestException('Ungültige Benachrichtigungs-Einstellung, erlaubt sind: ' . implode(', ', NotificationPolicy::MODES));
 		}
@@ -177,6 +183,9 @@ class WorkflowController extends OCSController {
 		// assertDeck() ran first, so an empty list here means "not there",
 		// not "Deck is unreachable".
 		$this->assertDeck();
+		if ($triggerDate === TriggerDate::START && !$this->deckService->supportsStartdate()) {
+			throw new OCSBadRequestException('Die installierte Deck-Version kennt kein Startdatum.');
+		}
 
 		// Only boards the user owns are listed, so this also enforces the
 		// owner rule. Archived boards stay listed (their workflows must stay
@@ -207,6 +216,7 @@ class WorkflowController extends OCSController {
 		int $boardId,
 		int $sourceStackId,
 		int $targetStackId,
+		string $triggerDate,
 		string $notifyMode,
 		string $notifyChannel,
 		bool $enabled,
@@ -215,6 +225,7 @@ class WorkflowController extends OCSController {
 		$workflow->setBoardId($boardId);
 		$workflow->setSourceStackId($sourceStackId);
 		$workflow->setTargetStackId($targetStackId);
+		$workflow->setTriggerDate($triggerDate);
 		$workflow->setNotifyMode($notifyMode);
 		$workflow->setNotifyChannel($notifyChannel);
 		$workflow->setEnabled($enabled);