14 Commits

Include renames

Author	SHA1	Message	Date
gnilebein	28b4edc811	revert 0e66319a06 ... revert Let each workflow watch the due date or the start date Deck 1.18 added a start date to cards (Card::$startdate), so a workflow no longer has to mean "overdue". Each rule now carries a date_field ('due' | 'start'), chosen in the settings form next to board and stacks. Existing rules keep the due date: the new column's default supplies it for every stored row, so there is no backfill step, and Workflow::getDateFieldOrDue() covers entities that were never near the database as well as hand-edited values. The controller is the one place that rejects an unknown value instead of normalising it - a client asking for a rule it would not get should hear about it. The probe for the field is property_exists(), not method_exists(): Deck's entities declare no getter as real code - getStartdate(), getDuedate(), even getId() all go through Entity::__call(), which method_exists() ignores by definition. A method_exists() guard would have been false on every Deck version and would have turned every start-date rule into a silent no-op. assertDeckAvailable() now also refuses Deck older than 1.18.0. That floor cannot live in appinfo/info.xml - neither the server's nor the app store's schema has an app-to-app dependency element - but <nextcloud min-version="34"> already implies it, since 1.18.x is the only Deck release line published for Nextcloud 34. isOverdue() becomes hasPassed(): one function for both dates, since the comparison and the argument against Deck's day-truncating getDaysUntilDue() are identical for either. Also carries a pending NcSelect icon-alignment fix that was already in the working tree. Bump to 34.1.0.	2026-08-26 07:10:55 +02:00
Patrick Niebeling	0e66319a06	Let each workflow watch the due date or the start date ... Deck 1.18 added a start date to cards (Card::$startdate), so a workflow no longer has to mean "overdue". Each rule now carries a date_field ('due' | 'start'), chosen in the settings form next to board and stacks. Existing rules keep the due date: the new column's default supplies it for every stored row, so there is no backfill step, and Workflow::getDateFieldOrDue() covers entities that were never near the database as well as hand-edited values. The controller is the one place that rejects an unknown value instead of normalising it - a client asking for a rule it would not get should hear about it. The probe for the field is property_exists(), not method_exists(): Deck's entities declare no getter as real code - getStartdate(), getDuedate(), even getId() all go through Entity::__call(), which method_exists() ignores by definition. A method_exists() guard would have been false on every Deck version and would have turned every start-date rule into a silent no-op. assertDeckAvailable() now also refuses Deck older than 1.18.0. That floor cannot live in appinfo/info.xml - neither the server's nor the app store's schema has an app-to-app dependency element - but <nextcloud min-version="34"> already implies it, since 1.18.x is the only Deck release line published for Nextcloud 34. isOverdue() becomes hasPassed(): one function for both dates, since the comparison and the argument against Deck's day-truncating getDaysUntilDue() are identical for either. Also carries a pending NcSelect icon-alignment fix that was already in the working tree. Bump to 34.1.0.	2026-08-25 15:28:30 +02:00
Patrick Niebeling	ce749e63a4	Fix overdue check to compare real timestamps, not whole calendar days ... WorkflowRunner::isOverdue() took Card::getDaysUntilDue(), which Deck computes by truncating both "now" and the due date to midnight before diffing. A card due earlier today therefore reported 0 days until due - not overdue - until the calendar date rolled over to the next day, so a card due "this morning" sat unmoved for up to 24h while one due "yesterday morning" moved immediately. isOverdue() now takes the due date and $now directly and compares them as real timestamps, matching what Deck's own UI shows. Bump to 34.0.2.	2026-08-25 13:48:02 +02:00
Patrick Niebeling	2d2f3ca19c	Fix overdue detection: stop discarding enriched cards for CardDetails wrappers ... getActiveCardsInStack() reassigned $cards to CardService::enrichCards()'s return value. That return value is an array of CardDetails wrappers whose own entity fields (duedate, stackId, ...) are never populated from the wrapped card - only its overridden jsonSerialize() reads through to them. So every card's getDuedate()/getDaysUntilDue() resolved to null, and WorkflowRunner::isOverdue() was always false: no workflow could ever match a card, regardless of its actual due date. enrichCards() already mutates the original $cards entries in place (labels, assigned users, comment counts, ...), so the fix is to keep using that array instead of capturing the CardDetails return value. Bump to 0.2.3.	2026-08-25 13:01:35 +02:00
Patrick Niebeling	7ca728e79c	Log matched and moved overdue cards in WorkflowRunner ... Adds an info-level log line when a card passes a workflow's overdue/ filter checks, and another once the move to the target stack succeeds - so a run can be traced per card/workflow in the log, filterable by the app id.	2026-08-25 12:20:28 +02:00
Patrick Niebeling	131ef2e938	Surface dead filters, and name board and stacks in the moved-card mail ... A filter whose entries have all been deleted from the board was the one failure mode of this app that was completely invisible: the workflow kept running, kept updating last_run and matched nothing, forever. It happens with deleted labels and just as easily when a filtered user loses board access, because Deck's BoardService::deleteAcl() calls assignedUsersMapper->deleteByParticipantOnBoard() and wipes that user's card assignments. Two low-stakes signals, no new column and no migration: - WorkflowRunner::warnAboutDeadFilters() logs a warning on every run. - workflowIssues in PersonalSettings.vue marks the row red. Deliberately no mail and no `enabled = false`. One deleted label out of three is harmless, and even a fully dead filter can be one board edit away from being live again. Both obey the rule the disable path already follows: only positive knowledge. DeckIntegrationService::findFilterOptions() therefore throws instead of degrading to [], unlike listLabels()/listParticipants(), where an empty list only means an empty dropdown. That also fixes an existing false positive of the same family: loadStacksFor() stored [] when the request failed, so a single failed fetch reported "Quell-Stapel und Ziel-Stapel nicht mehr vorhanden" for an untouched board. Failed requests now store null and are read as "unknown". The comparison itself lives in WorkflowRunner::findDeadFilters(), static and side-effect free like cardMatchesFilters(), with unit tests -- notably that an empty filter is never dead, which would otherwise flag every unfiltered workflow. Separately, the moved-card mail now names the board and both stacks. DeckIntegrationService::describeTargets() resolves the titles at most once per workflow run, and only when a card actually moved and the workflow wants a mail; unreadable titles degrade to #<id> rather than costing the user their notification.	2026-08-13 23:02:13 +02:00
Patrick Niebeling	b4057809ed	Run Deck as the workflow owner, and drop the job interval ... Workflows were being switched off with "its board no longer exists or is no longer available to you" for boards that were perfectly intact. Deck does not read the session for permissions. PermissionService -- the class behind every check, including the ones inside CardService::reorder() -- takes the current user as a plain `private ?string $userId`, filled from the app container's `userId` service (ISession::get('user_id'), registered shared). Pimple resolves that once per process and caches it, and ServerContainer caches Deck's app container just as long. In cron the value is null whenever a Deck-owned job ran earlier in the same pass, and otherwise the first workflow owner touched -- never the user being impersonated. null fails every check, so Deck answered NoPermissionException for an untouched board and findStackIds() read that as "the board is gone". IUserSession::setUser() never had any effect on this path. - DeckIntegrationService::beginUserContext()/endUserContext() pin PermissionService (mandatory), CardService, BoardService and ActivityManager (best effort) to the workflow owner, and restore them afterwards. If PermissionService cannot be pinned, the runner skips that user instead of acting under someone else's permissions. - findStackIds() now takes the uid as an argument and is assembled from pieces that cannot answer for the wrong user: BoardMapper and StackMapper carry no user state, and getPermissions() is handed the uid explicitly. It no longer goes through StackService::findAll(). - NoPermissionException is no longer treated as "board missing". Unknown failures throw, which leaves the workflow enabled. This also fixes the second half of the same defect: card moves silently failed for every user except the first one processed in a cron pass. Separately, RunWorkflowsJob is now a plain Job instead of a TimedJob and runs on every cron pass. The workflow_deck_automation.interval config key is gone. Time sensitivity is no longer merely declared but structurally unreachable: JobList::add() leaves the column at its TIME_SENSITIVE default, and the ratchet in setLastRun() only fires for TimedJob.	2026-08-13 22:40:57 +02:00
Patrick Niebeling	0eff367268	Handle workflows whose board or stack was deleted ... Deleting a board or stack left the workflow row pointing at nothing: Deck keeps the orphaned cards readable until its DeleteCron purges them, so the run kept failing on the move every few minutes, silently and forever. - The controller now rejects boards and stacks that do not exist (or are not the user's) on create and update, so no new broken row can be stored. - The settings list marks affected workflows in red instead of showing a row that looks healthy. - The background job disables such a workflow and mails its owner once. The mail ignores the notifyEmail flag: that one is about moved cards, this is a notice that the automation stopped. It stays a one-off because a disabled workflow is no longer picked up. The check deliberately goes through StackService::findAll() rather than BoardService::getUserBoards(): Deck injects the current user into BoardService as a string frozen at construction, so in the job -- one process, many users, a cached BoardService -- it would answer for the wrong user or for none, and every workflow on the instance would have been disabled. findStackIds() returns null only for a genuinely missing or forbidden board and throws for anything else, so a Deck outage skips the workflow instead of killing it.	2026-08-13 15:47:55 +02:00
Patrick Niebeling	ee72d6fcf9	Do not move cards that are in the trash ... Deck's CardMapper::findAllByStack() filters on stack_id and archived only -- there is no deleted_at condition -- so getActiveCardsInStack() also returned cards the user had deleted. They stay in the table until Deck's DeleteCron purges them, which is long enough for an overdue one to get moved out of the trash and back into a stack.	2026-08-13 15:36:39 +02:00
Patrick Niebeling	80371d48fb	Never let a throwable escape the workflow run ... Job::start() calls setLastRun() before run() and clears `reserved_at` only afterwards through setExecutionTime(), which is not in a finally block. Any uncaught throwable therefore leaves the job reserved, and JobList::getNext() skips reserved jobs until the reservation is 12 hours stale -- so a single failing workflow takes the whole app offline for half a day, while last_run still shows the start of that failed attempt. Wrap both loops so a failure is logged with its exception and the remaining users and workflows still run.	2026-08-13 15:24:16 +02:00
Patrick Niebeling	68d88e952b	Include the card description in the notification mail ... The mail named the card and the workflow but not what the card is about, which meant opening Deck to know whether the move mattered. The description is escaped explicitly: addBodyText() only calls htmlspecialchars() when it has to derive the plain-text part itself, and we pass both parts to get line breaks in the HTML body -- so escaping user input is on us. Long descriptions are cut at 2000 characters. Deck stores the description as Markdown; it is sent unrendered rather than pulling in a parser for one mail.	2026-08-13 15:01:53 +02:00
Patrick Niebeling	13903f8137	Hide inactive boards, keep source and target stack apart, make the interval configurable ... - Boards: BoardService::getUserBoards() defaults to $includeArchived = true, and that flag also gates the `deleted_at = 0` condition, so archived and trashed boards showed up in the dropdown. Request the filtered query instead, with a fallback to the no-arg call if the signature ever changes. Stacks need nothing: StackMapper::findAll() always filters deleted_at. - Each stack dropdown now hides whatever the other one holds, so source and target can no longer be set to the same stack. The save-time check stays as the backstop for rows stored before this rule. - RunWorkflowsJob reads its interval from config.php ('workflow_deck_automation.interval', seconds, default 300, clamped to a 60s minimum). TimedJob re-reads the interval on every cron pass, so a changed value takes effect without any occ command.	2026-08-13 14:33:28 +02:00
Patrick Niebeling	85b42d84c9	Fix unusable personal settings form: v8 Vue idioms and Deck relations ... The settings page rendered, but nothing in it worked: - All NcSelect dropdowns showed "undefined" for every option. In @nextcloud/vue 9 the `label` prop is vue-select's option display *key*, not a caption, so `label="Board"` read `option.Board`. Use `input-label`. - Saving always failed with "Bitte einen Titel angeben". Vue 3 dropped `.sync`; NcTextField and NcCheckboxRadioSwitch bind via `modelValue`, so `:value.sync` / `:checked.sync` never wrote back. Use `v-model`. - NcButton's style prop is now `variant`, `type` is the native button type and `native-type` is gone. `type="tertiary"` rendered `<button type="tertiary">`, which HTML falls back to `submit` for, making the cancel button submit the form. - The user dropdown was always empty. Deck's RelationalEntity replaces resolved relations with a RelationalObject once an entity is enriched, so `$acl->getParticipant()` returns that wrapper and the uid lives in `getPrimaryKey()` -- probing for `getUID()` yielded null. This also broke the background job's assigned-user filter, which shares the extractor. - A board's ACL never contains its owner (a private board has an empty ACL), so participants are now seeded with the owner, group ACL entries are expanded via IGroupManager and display names resolved via IUserManager. - One board appeared twice: getUserBoards() merges own/group/circle boards and includes archived and trashed ones. Deduplicate by id and drop those. Also keep one failing lookup in onBoardChange from taking the other two dropdowns down with it, and document all of the above in CLAUDE.md.	2026-08-13 14:13:11 +02:00
Patrick NiebelingandClaude Sonnet 5	300acde27e	Add Deck workflow automation Nextcloud app ... Ports the standalone due-date cron script into a proper Nextcloud 34 app with a personal-settings UI, per-user workflow configuration (source/target stack, assigned-user and label filters, email notification), a TimedJob background runner, and Gitea CI pipelines. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-13 10:13:05 +02:00