Patrick Niebeling
0e66319a06
Deck 1.18 added a start date to cards (Card::$startdate), so a workflow
no longer has to mean "overdue". Each rule now carries a date_field
('due' | 'start'), chosen in the settings form next to board and stacks.
Existing rules keep the due date: the new column's default supplies it
for every stored row, so there is no backfill step, and
Workflow::getDateFieldOrDue() covers entities that were never near the
database as well as hand-edited values. The controller is the one place
that rejects an unknown value instead of normalising it - a client
asking for a rule it would not get should hear about it.
The probe for the field is property_exists(), not method_exists():
Deck's entities declare no getter as real code - getStartdate(),
getDuedate(), even getId() all go through Entity::__call(), which
method_exists() ignores by definition. A method_exists() guard would
have been false on every Deck version and would have turned every
start-date rule into a silent no-op.
assertDeckAvailable() now also refuses Deck older than 1.18.0. That
floor cannot live in appinfo/info.xml - neither the server's nor the app
store's schema has an app-to-app dependency element - but
<nextcloud min-version="34"> already implies it, since 1.18.x is the
only Deck release line published for Nextcloud 34.
isOverdue() becomes hasPassed(): one function for both dates, since the
comparison and the argument against Deck's day-truncating
getDaysUntilDue() are identical for either.
Also carries a pending NcSelect icon-alignment fix that was already in
the working tree.
Bump to 34.1.0.
44 lines
1.5 KiB
PHP
44 lines
1.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace OCA\WorkflowDeckAutomation\Tests\Unit\Db;
|
|
|
|
use OCA\WorkflowDeckAutomation\Db\Workflow;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class WorkflowTest extends TestCase {
|
|
public function testDateFieldDefaultsToDueWhenUnset(): void {
|
|
// The column default covers rows written before date_field existed,
|
|
// but an entity built in PHP has never been near the database.
|
|
$this->assertSame(Workflow::DATE_FIELD_DUE, (new Workflow())->getDateFieldOrDue());
|
|
}
|
|
|
|
public function testDateFieldIsKeptWhenKnown(): void {
|
|
$workflow = new Workflow();
|
|
|
|
$workflow->setDateField(Workflow::DATE_FIELD_START);
|
|
$this->assertSame(Workflow::DATE_FIELD_START, $workflow->getDateFieldOrDue());
|
|
|
|
$workflow->setDateField(Workflow::DATE_FIELD_DUE);
|
|
$this->assertSame(Workflow::DATE_FIELD_DUE, $workflow->getDateFieldOrDue());
|
|
}
|
|
|
|
public function testUnknownDateFieldFallsBackToDue(): void {
|
|
// A hand-edited row must not silently switch a workflow to a trigger
|
|
// nobody configured; the due date is what every workflow meant before
|
|
// this choice existed.
|
|
$workflow = new Workflow();
|
|
$workflow->setDateField('whenever');
|
|
|
|
$this->assertSame(Workflow::DATE_FIELD_DUE, $workflow->getDateFieldOrDue());
|
|
}
|
|
|
|
public function testDateFieldIsSerialisedForTheSettingsUi(): void {
|
|
$workflow = new Workflow();
|
|
$workflow->setDateField(Workflow::DATE_FIELD_START);
|
|
|
|
$this->assertSame(Workflow::DATE_FIELD_START, $workflow->jsonSerialize()['dateField']);
|
|
}
|
|
}
|