revert 0e66319a06

revert Let each workflow watch the due date or the start date

Deck 1.18 added a start date to cards (Card::$startdate), so a workflow
no longer has to mean "overdue". Each rule now carries a date_field
('due' | 'start'), chosen in the settings form next to board and stacks.

Existing rules keep the due date: the new column's default supplies it
for every stored row, so there is no backfill step, and
Workflow::getDateFieldOrDue() covers entities that were never near the
database as well as hand-edited values. The controller is the one place
that rejects an unknown value instead of normalising it - a client
asking for a rule it would not get should hear about it.

The probe for the field is property_exists(), not method_exists():
Deck's entities declare no getter as real code - getStartdate(),
getDuedate(), even getId() all go through Entity::__call(), which
method_exists() ignores by definition. A method_exists() guard would
have been false on every Deck version and would have turned every
start-date rule into a silent no-op.

assertDeckAvailable() now also refuses Deck older than 1.18.0. That
floor cannot live in appinfo/info.xml - neither the server's nor the app
store's schema has an app-to-app dependency element - but
<nextcloud min-version="34"> already implies it, since 1.18.x is the
only Deck release line published for Nextcloud 34.

isOverdue() becomes hasPassed(): one function for both dates, since the
comparison and the argument against Deck's day-truncating
getDaysUntilDue() are identical for either.

Also carries a pending NcSelect icon-alignment fix that was already in
the working tree.

Bump to 34.1.0.

tests/Unit/Db/WorkflowTest.php

@@ -1,43 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace OCA\WorkflowDeckAutomation\Tests\Unit\Db;
-
-use OCA\WorkflowDeckAutomation\Db\Workflow;
-use PHPUnit\Framework\TestCase;
-
-class WorkflowTest extends TestCase {
-	public function testDateFieldDefaultsToDueWhenUnset(): void {
-		// The column default covers rows written before date_field existed,
-		// but an entity built in PHP has never been near the database.
-		$this->assertSame(Workflow::DATE_FIELD_DUE, (new Workflow())->getDateFieldOrDue());
-	}
-
-	public function testDateFieldIsKeptWhenKnown(): void {
-		$workflow = new Workflow();
-
-		$workflow->setDateField(Workflow::DATE_FIELD_START);
-		$this->assertSame(Workflow::DATE_FIELD_START, $workflow->getDateFieldOrDue());
-
-		$workflow->setDateField(Workflow::DATE_FIELD_DUE);
-		$this->assertSame(Workflow::DATE_FIELD_DUE, $workflow->getDateFieldOrDue());
-	}
-
-	public function testUnknownDateFieldFallsBackToDue(): void {
-		// A hand-edited row must not silently switch a workflow to a trigger
-		// nobody configured; the due date is what every workflow meant before
-		// this choice existed.
-		$workflow = new Workflow();
-		$workflow->setDateField('whenever');
-
-		$this->assertSame(Workflow::DATE_FIELD_DUE, $workflow->getDateFieldOrDue());
-	}
-
-	public function testDateFieldIsSerialisedForTheSettingsUi(): void {
-		$workflow = new Workflow();
-		$workflow->setDateField(Workflow::DATE_FIELD_START);
-
-		$this->assertSame(Workflow::DATE_FIELD_START, $workflow->jsonSerialize()['dateField']);
-	}
-}

tests/Unit/Service/WorkflowRunnerFilterTest.php

@@ -9,30 +9,30 @@ use OCA\WorkflowDeckAutomation\Service\WorkflowRunner;
 use PHPUnit\Framework\TestCase;
 
 class WorkflowRunnerFilterTest extends TestCase {
-	public function testHasPassedReturnsFalseWithoutADate(): void {
-		$this->assertFalse(WorkflowRunner::hasPassed(null, new DateTimeImmutable('2026-01-15 12:00:00')));
+	public function testIsOverdueReturnsFalseWithoutDueDate(): void {
+		$this->assertFalse(WorkflowRunner::isOverdue(null, new DateTimeImmutable('2026-01-15 12:00:00')));
 	}
 
-	public function testHasPassedReturnsFalseForAFutureDate(): void {
+	public function testIsOverdueReturnsFalseForFutureDueDate(): void {
 		$now = new DateTimeImmutable('2026-01-15 12:00:00');
-		$this->assertFalse(WorkflowRunner::hasPassed($now->modify('+1 hour'), $now));
-		$this->assertFalse(WorkflowRunner::hasPassed($now->modify('+3 days'), $now));
+		$this->assertFalse(WorkflowRunner::isOverdue($now->modify('+1 hour'), $now));
+		$this->assertFalse(WorkflowRunner::isOverdue($now->modify('+3 days'), $now));
 	}
 
-	public function testHasPassedReturnsTrueForAPastDate(): void {
+	public function testIsOverdueReturnsTrueForPastDueDate(): void {
 		$now = new DateTimeImmutable('2026-01-15 12:00:00');
-		$this->assertTrue(WorkflowRunner::hasPassed($now->modify('-1 hour'), $now));
-		$this->assertTrue(WorkflowRunner::hasPassed($now->modify('-30 days'), $now));
+		$this->assertTrue(WorkflowRunner::isOverdue($now->modify('-1 hour'), $now));
+		$this->assertTrue(WorkflowRunner::isOverdue($now->modify('-30 days'), $now));
 	}
 
-	public function testHasPassedReturnsTrueForATimeEarlierTheSameDay(): void {
+	public function testIsOverdueReturnsTrueForADueTimeEarlierTheSameDay(): void {
 		// Regression: comparing whole calendar days (as Deck's own
 		// Card::getDaysUntilDue() does) reports a card due earlier today as
 		// "0 days until due", not overdue, until the calendar date rolls
 		// over - holding every card back for up to 24h after it actually
-		// fell due. hasPassed() must compare the real timestamps instead.
+		// fell due. isOverdue() must compare the real timestamps instead.
 		$now = new DateTimeImmutable('2026-01-15 12:00:00');
-		$this->assertTrue(WorkflowRunner::hasPassed(new DateTimeImmutable('2026-01-15 06:00:00'), $now));
+		$this->assertTrue(WorkflowRunner::isOverdue(new DateTimeImmutable('2026-01-15 06:00:00'), $now));
 	}
 
 	public function testNoFiltersMatchesAnyCard(): void {